Skip to content

Resolve "fix(viz): changing viewport while a notification is active crashes"

Flavien BRIDAULT requested to merge 1136-fix-viz-changing-viewport-while-a-notification-is-active-crashes into dev

Description

This removes one line in the render texture creation code that reset the camera viewport to the previous one. This code was taken from Ogre itself and I admit I wasn't sure if it was really useful or not. I understand now that it actually changes the viewport pointer in the camera. Most of the time this has no effect since Ogre probably reset it afterwards. But I suspect that in the case reported, no rendering occurs between the creation and the resize and so, the pointer is still pointing to the old viewport...

In practice, this fixes the issue and apparently doesn't alter the other features.

Closes #1136 (closed)

How to test it?

  • See #1136 (closed).
  • Check potential regressions by running a few apps.
Edited by Flavien BRIDAULT

Merge request reports