Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • sight sight
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 121
    • Issues 121
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Sight
  • sightsight
  • Merge requests
  • !865

fix(ui): fix password management for preferences

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Didier WECKMANN requested to merge 1023-fix-core-password-management-is-broken into dev Jan 13, 2023
  • Overview 6
  • Commits 1
  • Pipelines 10
  • Changes 32

Description

  • restore BadPassword exception
  • changed inputDialog to return value and a boolean to know if user canceled it
  • allow closing sight if user cancel or if wrong password have been entered 3 times
  • updated ExActivities plugin configuration to force encryption and to exit on password error
  • "once" passwod policy configuration has been changed to "global": "global" which means the global password will be used, if set, otherwise or if wrong, it will be asked to the user
  • "default" configuration has been removed. User should simply not set any configuration if they want the default to apply

Closes #1023 (closed)

How to test it?

  • Delete ExActivities preferences
    rm -rf  ~/.config/sight/ExActivities
  • Launch ExActivities
  • test "cancel" -> the application should exit
  • test "ok" with empty password -> empty password is used, but still encrypted with salt...
  • relaunch and enter a wrong password (remember, the good one from previous step is "") -> message with retry / cancel
  • retry 3x -> application exit
  • cancel -> application exit
  • good "" password -> ok !
Edited Jan 25, 2023 by Didier WECKMANN
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 1023-fix-core-password-management-is-broken