Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • sight sight
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 121
    • Issues 121
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Sight
  • sightsight
  • Merge requests
  • !847

fix(build): child repository installer

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Flavien BRIDAULT requested to merge fix-child-repository-installer into dev Nov 23, 2022
  • Overview 2
  • Commits 1
  • Pipelines 20
  • Changes 12

Description

The installer of applications of child repositories using sight plus another repository should now be functional again.

The main fix is to give a relocatable path to the executable, like sightrun. Now we locate it relative to the launcher script location.

Similarly, extra modules were given with absolute paths. We now use a relative path. We needed to modify Sight to accept relative paths, which are interpreted as relative to the executable path (and not the current directory, which is too fragile).

Last, when fixing this, we discovered that the extra modules were installed in the sight directory. This is wrong because they could overwrite sight modules if they have the same name. This was fixed to use a separate folder according to the name of the repository.

How to test it?

  • For Sight installers, the CI deploy tests should be sufficient
  • For the child repositories, a CI deploy test was added. You may also test manually.
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-child-repository-installer