Skip to content

Resolve "misc: remove deprecated symbols in Sight 22.0"

Flavien BRIDAULT requested to merge 944-misc-remove-deprecated-symbols-in-sight-22-0 into dev

Description

All deprecated symbols in Sight 22.0 were removed. All 3rd part libraries deprecation warnings were fixed.

Closes #944 (closed)

Extra fix

While removing obsolete code in SFrameMatrixSynchronizer, a crash appeared in ExFrameByFrame. We used to allow to have the pixel format not defined in the image because of a deprecation phase. This is no longer the case for a long time. But somehow, we force a first sync, while the timeline is not yet initialized. thus we lie in this case. This is wrong and I think we should not force this first sync. I removed it but we need to do extended testing to verify it does not break anything.

How to test it?

  • Usual testing...
  • Manual search in the code to see if there is nothing left?
  • ...or do a complete build, grep the log for deprecation warnings
  • ...and launch some applications and check if there is any deprecation warning in the build logs
  • Extended testing in applications that use SFrameMatrixSynchronizer
Edited by Flavien BRIDAULT

Merge request reports