(build): default to warnings as errors
Description
On our journey to remove all warnings from Sight, we propose now, by default, to consider all warnings as errors.
- all targets which specified "WARNINGS_AS_ERRORS ON" now specify nothing
- all targets which specified nothing now specify "WARNINGS_AS_ERRORS OFF"
- a few targets which specified nothing, with less than 4 warnings reported, now specify "WARNINGS_AS_ERRORS ON", and their warnings were fixed.
This MR doesn't remove all warnings from Sight yet. But it will prevent adding new targets without checking warnings.
See #405 (closed)
How to test it?
- Test some apps