Skip to content

Draft: (build): FTBFS on i386

Flavien BRIDAULT requested to merge 583-build-ftbfs-on-i386 into dev

Description

This corrects some warnings reported as errors in fwData. The main change is that ::fwData::Mesh::Id is set to size_t instead of std::uint64_t. 32 bits integer would probably be sufficient but it makes more sense, in my opinion, to stick to this architecture-dependent integer type, since it is designed for memory buffers and pointer arithmetics. The only doubt I have is the need to duplicate this type in MeshIterators.hpp. It is necessary otherwise we get stuck in circular header dependencies. We could extract it in a new common header but then we would need to rename its scope, since it would lie outside the class.

Closes #583 (closed)

How to test it?

  • Build and run
  • We could add an i386 CI job, but really I would rather run it only once a day or something.
Edited by Romain MANCIAUX

Merge request reports