Skip to content

(fwIO): implement a fail/sucess notification on all readers and writers.

Luis MENDOZA requested to merge 298-fwio-implement-a-fail-sucess-notification-on-all-readers-and-writers into dev

What does this MR do?

Closes #298 (closed)

Adds a new member status boolean to IReader and IWriterand all of their inherited implementations.

The following implementation of those interfaces have been modified :

Readers :

  • ioAtoms/SReader
  • ioCalibration/SOpenCVReader
  • ioData/SAttachmentSeriesReader
  • ioData/STrianMeshReader
  • ioData/TransformationMatrix3DReaderService
  • ioDcmtk/SSeriesDBReader
  • ioGdcm/SDicomSeriesDBReader
  • ioGdcm/SSeriesDBReader
  • ioITK/InrImageReaderService
  • ioITK/SInrSeriesDBReader
  • ioITK/SImageReader
  • ioVTK/SModelSeriesReader
  • ioVTK/SSeriesDBReader
  • ioVTKGdcm/SSeriesDBLazyReader
  • ioVTKGdcm/SSeriesDBReader

Writers :

  • ioAtoms/SWriter
  • ioCalibration/SCalibrationImagesWriter
  • ioCalibration/SOpenCVWriter
  • ioData/MeshWriterService
  • ioData/TransformationMatrix3DWriterService (great name btw).
  • ioGdcm/SDicomSeriesWriter
  • ioGdcm/SSeriesDBWriter
  • ioGdcm/SSurfaceSegmentationWriter
  • ioITK/InrImageWriterService
  • ioITK/JpgImageWriterService
  • ioITK/SJpgImageSeriesWriter
  • ioITK/SImageSeriesWriter
  • ioQt/SPdfWriter
  • ioVTK/SImageSeriesWriter
  • ioVTK/SImageWriter
  • ioVTK/SMeshWriter
  • ioVTK/SModelSeriesObjWriter
  • ioVTK/SModelSeriesWriter
  • ioVTKGdcm/SImageSeriewWriter

The following implementation of those interfaces have not been modified : Note: by default we consider that a non modified reader always return success...

Readers:

  • ioTimeline/SMatricesRead : this service is to complex for a simple muggle like me.
  • ioZMQ/SAtomNetworkReader : one of those that do a bit more than reading... 🙄
  • ioZMQ/SImageNetworkReader : same here

Writers:

  • ioTimeline/SMatrixWriter : see above
  • ioZMQ/SAtomNetworkWriter : idem
  • ioZMQ/SImageNetworkWriter : idem
  • videoOpenCV/SFrameWriter : not the actual behaviour we expect.

How to test it?

Or you can test any of the modified services on your application and check that everything is still working smoothly.

Additional tests to run

(If you need some specific test e.g Windows compilation...)

  • Build on Windows
  • Build on linux
  • Build on MacOs

Associated Issues/Merge Requests

  • Issues
    • Fixes Sight/sight#298
Edited by Marc SCHWEITZER

Merge request reports