Skip to content

feat(ui): overlay should honor widgets size hints / minimum size hints

Didier WECKMANN requested to merge 1257-feat-ui-overlay-should-honor-widgets-size-hints-minimum-size-hints into dev

Description

There was a bug with Toolbars in overlay layout, which prevented to "reserve" the right size. This has been "fixed" / "mitigated" by calling QWidget::adjustSize() at strategic places. Still, normally we should not have to do this, even for overlay. Anyway, the workaround should not have any side effect.

Breaking change(s)

Normally none, but you should check your application if toolbars in overlay are used.

Results

You don't have to specify the size of the overlay anymore when dealing with toolbars (it should already have worked for other widget !). The size of the overlay should be fairly minimal.

How to test it?

  • Test with Sight_viewer (you can put a background on the overlay view to visualize the toolbar size)
  • Check the toolbars...

Decreased code coverage

A bit hard to test with automated tests...

Related issue(s)

Relates #1289 (closed)

Closes #1257 (closed)

Merge request reports