(core): default password built even when disabled
Description
The build of Sight 21.1.1 on Debian initially failed because SIGHT_DEFAULT_PASSWORD
is not disabled properly, whilst it should be by default. This feature relies on the __TIME__
macro, which is forbidden by the Wdate-time
flag which is enabled by default on our Debian build.
Steps to reproduce
- Add
Wdate-time
flag manually - Build
core
- Observe the build fails
Functional specifications
We must really disable SIGHT_DEFAULT_PASSWORD
when it is not user specified.
Technical specifications
The macro SIGHT_DEFAULT_PASSWORD
is empty by default but still defined. Thus #ifdef SIGHT_DEFAULT_PASSWORD
succeeds while it should fail.
Do not define the macro when it is empty.