(core): mismatch between reconstruction input and Material constness in SReconstruction
Summary
The following discussion from !704 (merged) should be addressed:
-
@dweckmann started a discussion: Then I really think we should rather use a data::Access::inout for m_reconstruction. There are no guaranty that one day we won't modify the material in this function. It also ensure we use a write lock when accessing reconstruction's material. Sorry to be a bit pedantic about the use of const_pointer_cast..
We agreed to open an issue about this...
Steps to reproduce
Not sure that a bug will appears.
Possible fixes
Another possible workaround is to set Reconstruction as a inout data of SReconstruction, but doing so implies to modify all other adaptors (SModelSeries, SMesh...) to homogenize reading.