(core): move remaining misplaced files
Description
Some files are still misplaced and get through the great replacement refactoring from Sight 21.
This includes:
-
BresenhamLine: Actually this is used in LineDrawer...libs/filter/image/BresenhamLine.cpp libs/filter/image/BresenhamLine.hpp libs/filter/image/test/tu/BresenhamLineTest.hpp libs/filter/image/test/tu/BresenhamLineTest.cpp
-
LineDrawerAnd having LineDrawer there makes sense in this module...libs/filter/image/LineDrawer.cpp libs/filter/image/LineDrawer.hpp libs/filter/image/test/tu/LineDrawerTest.hpp libs/filter/image/test/tu/LineDrawerTest.cpp
EDIT @fbridault:
service:
-
I propose we don't keep service interfaces that are not used in only one category. They should go in libs/category/base. For instance: - IRGBDGrabber -> io
- ICalibration -> calibration ?
-
IOperator should be renamed as IFilter? -
IParametersService: should not be a service, but just a utility interface -
INetworkListener/Sender: it looks like interfaces are identical, they could be placed next to other service interface or io_base ?I don't get it... -
pchServices/pchServicesOmp -> pchService/pchServiceOmp -
sight::module::ui::dicom::SSeriesDBMerger -> sight::module::ui::base and rename, since it pushes series into a seriesDB. A merge occurs with two identical objects. -
IRender interface seems also uselessWell, it's used... -
SUltrasoundMesh is duplicated
Also, some classes may be obsolete and should be removed. Additional thinking could be needed.
This includes:
-
SModelSeriesObjWriterIt is not really a duplicate ofSModelSeriesWriter
because it writes the mesh and the reconstruction, not only the meshmodules/io/vtk/SModelSeriesObjWriter.cpp modules/io/vtk/SModelSeriesObjWriter.hpp
Proposal
Use magical scripts from @fbridault.
Outcomes
All files are correctly placed in the right category