(ui): sight_calibrator crashes when opening captured images
Description
sight_calibrator
crashes when opening captured images. Also it fails to save captured images.
Steps to reproduce
First problem
- Launch
sight_calibrator
and the calibration activity - Pick a recorded video of calibration like https://cloud.ircad.fr/f/4939039
- Change the checkerboard properties accordingly (8x6 with the above sample video)
- Capture an image with the '+' on the left panel
- Double-click on the image in the tree view
- Observe the crash
Second problem
- Launch
sight_calibrator
and the calibration activity - Pick a recorded video of calibration like https://cloud.ircad.fr/f/4939039
- Change the checkerboard properties accordingly (8x6 with the above sample video)
- Capture several images with the '+' on the left panel
- Click on the button to save the images
- Select a folder
- Open the folder in a file explorer
- Observe the folder is empty
Functional specifications
- This should not crash and we should see the captured image in a modal window with the detected points.
- We should be able to save images.
Technical specifications
The crash occurs because of a API breakage with the layer setup:
[3809][00:00:10.192055][fatal] [libs/viz/scene3d/render.cpp:532] Assertion '!_scene_id.empty()' failed: Empty sceneID
zsh: trace trap (core dumped) bin/sight_calibrator --clog --log-info
Just pass the layer id using the C++ function and not the XML configuration in sight::module::viz::scene3d::adaptor::video
.
For the saving, this is a regression that skips the configure()
for all writers that support the folder
mode. The configure
fails because the <folder>
tag is not present whereas it is optional.
Test plan
Repeat steps to reproduce.