(ui): preferences reset at each commit
Description
The preferences, i.e, the size of the main window, are reset whenever the current HEAD on git changes.
Steps to reproduce
- Build
SightViewer
- Run and maximize the main window
- Exit
- Run
SightViewer
- Observe the window is maximized
- Create a commit with some random blank modifications (spaces for instances)
- Run
SightViewer
- Observe the window is not maximized
Functional specifications
We use the <name/>
attribute of the SFrame to specify the key in preferences. This is wrong because we recently added the commit number in the app name to display it in the title bar, which is quite convenient.
I propose to add a new attribute <version/>
in SFrame
so that we can optionally display the version number in the title bar. And this was we separate the title which can be used safely for the preference key.
Technical specifications
- Add the attribute
- Modify applications that display the version number
Test plan
- Repeat reproduce steps