fix(viz): finishing shape extrusion with double tap on touchscreen doesn't work
Description
When using the shape extruder, it is impossible to finish the extrusion because double tapping will add two new points instead of finishing the extrusion.
Steps to reproduce
- Launch SightViewer on a touchscreen
- Start an extrusion
- Notice that double-tapping will add two points instead of finishing the extrusion
This bug appears at least on KDE, other platforms weren't tested.
Proposal
Optional section to give some functional or technical hints
Functional specifications
Make finishing shape extrusion work on touchscreen.
Technical specifications
It seems that in SShapeExtruder::buttonDoublePressEvent, when using a touchscreen, near
variable will always be false, as such the shape extruder will never run. I don't understand what the purpose of this variable is, but when the condition is removed, the shape extruder seems to work correctly, both with a touchscreen and the mouse.
Test plan
Manual testing, maybe GUI tests if they are sensible to this bug.