Skip to content

(codingstyle): skip header guard test for PCH

Flavien BRIDAULT requested to merge 23-pch-compiling-emits-a-warning-when-using-pragma-once into dev

What does this MR do?

This skips the header guard test for pch, because #pragma once raises an error when compiling a pch.

We could have restored the old code that automatically format the header guard, but I think this is overkill as we do not modify pch very often.

How to test it?

  • Execute sheldon on a pch and observe that it does not complain about the header guard.
  • Execute sheldon on a regular header file:
    • with a header guard and notice that sheldon raises an error
    • with a #pragma once and notice that sheldon does not raise an error
    • without any header guard or #pragma once and notice that sheldon raises an error

Associated Issues/Merge Requests

Edited by Flavien BRIDAULT

Merge request reports