Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • sight sight
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 121
    • Issues 121
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Sight
  • sightsight
  • Merge requests
  • !860

enh(test): add tests for a real world application

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Lucas SCHMIDT requested to merge 998-enh-test-add-tests-for-a-real-world-application into dev Jan 02, 2023
  • Overview 16
  • Commits 14
  • Pipelines 9
  • Changes 131

Description

A real world application needed more tests. Some tests were added on the part of the code it relies on.

Closes #998 (closed)

How to test it?

Run the new tests.

Additional tests/tasks to run

Fix the discovered bugs:

  • data::Array::resize crashes when its buffer object is set to nullptr beforehand. The code should either handle this case, or the documentation should mention that this use case isn't supported.
  • Iterators in data::CalibrationInfo doesn't seem to work.
  • io::base::writer::GzBufferImageWriter::write always fails with either an exception or an assert.
  • Version field isn't set in DicomSRNode, probably because of a typo in DicomSRNode::createConceptNameCodeSequence.
  • When using io::vtk::helper::Mesh::toVTKMesh with a tetra mesh, but point id list in the resulting mesh is always empty.
  • "removeIfPresent" mode in module::data::SManage crashes when used with data::Vector because of a typo.
  • When using module::data::SSeriesSignal with no filter, no series are signaled, though one would expect that all are signaled.
  • Using module::data::SSeriesSignal with an "exclude" filter doesn't work as expected.
  • When using module::io::session::SReader with password.policy=always, the service won't ask for the password again if the user makes a mistake.
Edited Jan 26, 2023 by Lucas SCHMIDT
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: 998-enh-test-add-tests-for-a-real-world-application