Skip to content

fix(build): fix Clang-tidy warnings

Lucas SCHMIDT requested to merge 887-enh-ci-fix-clang-tidy-warnings into dev

Description

We added Clang-tidy in our CI, and it discovered some problems in Sight code. We must fix them to improve Sight code quality, and we may then upgrade these warnings to errors.

Closes #887 (closed) Closes #911 (closed)

How to test it?

Launch Clang-tidy, no warnings must remain. Launch the tests and the applications, there must be no regressions.

Additional tests/tasks to run

There are Clang-tidy errors in the CI because Clang-tidy is launched in Release mode, and as such finds false positives because there is suppressed code (for example, it will find a null dereference though there is a check in debug mode). With sight-git#63 (closed), Clang-tidy will use Debug mode, so these warnings will disappear.

Edited by Lucas SCHMIDT

Merge request reports