Skip to content

Resolve "(ci): licence check still fails"

Flavien BRIDAULT requested to merge 818-ci-licence-check-still-fails into dev

Description

Merging a feature branch for the linter is problematic for the date handling. Doing so "resets" all dates to the current year, instead of using the date of each individual commit.

We propose here to no longer merge in the lint phase. There should be no problem invoking sheldon with a commit range instead of a stage of modified files. Sheldon is then able to retrieve the date from each individual commit.

Closes #818 (closed)

How to test it?

Observe that all branches on Sight that currently fails in the lint phase because of the date check now succeed when rebasing on this commit e8a60414

Edited by Flavien BRIDAULT

Merge request reports