Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • sight sight
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 121
    • Issues 121
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Issue
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Sight
  • sightsight
  • Issues
  • #999
Closed
Open
Issue created Nov 10, 2022 by Marc SCHWEITZER@mschweitzer🚴Maintainer

enh(io): use variant slot for parameters changed in grabbers

Description

Since SParameters uses a unique slot (variant-typed) for parameters changes, we can do the same on all Grabber services for both slot and signals.

Proposal

  • create signals/ slots parameterChanged(parameters_t, std::string) in IGrabber
  • replace every intChanged, boolChanged etc by the new one.
  • replace also the forwards signals in SGrabberProxy

Functional specifications

  • Behavior should remain the same, it will only reduce the number of slots / signals to a unique one.

Technical specifications

  • We need to get the variant type used by SParameters by including #include <ui/base/parameter.hpp>
  • A lot of xml configuration needs to be updated along with channels

Test plan

  • Test applications that uses video (using SGrabberProxy and using a specific grabber)
Assignee
Assign to
Time tracking