(build): core doesn't not enable -Werror while it is supposed to
Summary
I just noticed that some warnings appear when build sight_core
, whereas it defines WARNINGS_AS_ERRORS
.
This may be a regression after merging !627 (merged)
Steps to reproduce
Run ninja core
and observe the warnings.
Dev environment
- OS: Linux
- CMake version: 3.19
- Compiler: gcc10
- Build type: debug
Possible fixes
sight_core
builds an object library, I suspect the -Werror flag is not set on the object library.