refactor(core): inherit data::Activity from std container
Description
data::Activity
is basically just a std::map
of data::Object
, exactly like a data::Composite
. The only difference is that it contains a string as an identifier. The current problem is that it contains a data::Composite
. If we inherit from a data::Composite
, we could reuse many services that manipulate data::Composite
like SManage
, instead of modifying these services to handle data::Activity
specifically.
Functional specifications
Modify data::Activity
to inherit from data::Composite
.
Technical specifications
- Modify the inheritance
- Remove
getData
andsetData
everywhere - Modify the serialisation and keep the compatibility with previous versions
Test plan
Existing automatic tests should be sufficient.