fix(ci): fix Clang-tidy error code ignored when using HTML report mode
Description
When the HTML report mode is used, Clang-tidy error code is discarded. As such, when using warnings as errors, the Clang-tidy hook will report a success even if errors are present.
Steps to reproduce
- Take a file with a Clang-tidy error inside
- Run Sheldon where both warnings as errors and HTML report mode are enabled
- The warnings are reported as errors, but Clang-tidy hook will return successfully
Proposal
The p
variable for Clang-tidy process is reused for the aha process used to generate the HTML report. Another name should be used for the aha process.
Functional specifications
Clang-tidy warnings as errors works correctly when used with HTML report mode.
Technical specifications
Rename p
variable for the aha process.
Test plan
It works.