For the 24.0 release to come the deprecated code should be removed. By the way, we also have some remnants of pre-23.0 that should be removed.
No functional change should occur, so if any deprecated code is used, it should be ported to the new API.
Delete the following services:
sight::module::ui::com::signal
sight::module::ui::com::starter
sight::module::ui::default_action
Delete the following functions:
sight::core::tools::system::get_temp_path()
sight::core::tools::system::get_temporary_folder()
If necessary, port user code to the new corresponding API.
CI should be sufficient.
Yep I agree as it is done, I'll be closing it
Could you update the date here ? (Only 2024)
In auto
mode, adaptors of viz::scene3d
can request a render of the 3d scene. To improve performance, it can be desirable to skip this request if the adaptor is not visible. The update of the graphic data is of course not discarded, just the rendering.
In the app of the depending merge-request:
And please don't tell me "This is Ogre."
Since a layouting problem has been discovered, or maybe rediscovered (#1254), we need to fix it or at least clarify this before merging this.
Flavien BRIDAULT (e768f144) at 27 Mar 15:43
enh(viz): skip rendering request when an adaptor is not visible
Flavien BRIDAULT (41399e49) at 27 Mar 14:20
enh(viz): skip rendering request when an adaptor is not visible
Didier WECKMANN (5718c5f3) at 27 Mar 09:59
enh(ui): better simultaneous job management
If it's any help I'm loading this image https://cloud.ircad.fr/f/1558034
I am however encountering a crash... Not a crucial one though :
tuto07_generic_scene
Yep, this fixed the issue.
Didier WECKMANN (72a7166b) at 27 Mar 08:15
enh(ui): better simultaneous job management
Well you could test again as I've made some change recently. I've no clue with the open dialog issue, and I'm not sure if I have any control on it...
Didier WECKMANN (c58a4622) at 26 Mar 21:32
enh(ui): better simultaneous job management
Didier WECKMANN (040a21f0) at 26 Mar 21:08
enh(ui): better simultaneous job management
Tried finding a mesh that slows the process as much as possible... if you have any bulky mesh that would make the loading process slower, that would highlight my point.
While testing I found a little behavioral change compared the the job bar, in the video below you'll see that the first part (the job bar) as I load a second image, the file system closes and then the progress bar finishes. With the progress bar I found that the file system lags a bit behind... (second part of the video). Would that be something to look out for?
simplescreenrecorder-2024-03-26_16.41.58.mkv
Note that this only occurs when loading the image twice so...
Didier WECKMANN (5966a647) at 26 Mar 16:38
enh(ui): better simultaneous job management
Alexandre ANCEL (3d868d37) at 26 Mar 15:49
feat(core): update dicom properties
... and 12 more commits