GitLab

Remove extra space in R2VB program preprocessor definitions. Sadly, this prevented the preprocessor defines of the R2VB geometry programs to be parsed properly, thus causing rendering issues.

Closes sight/sight#778

See merge request sight-club/sight!1

Sadly, this prevented the preprocessor defines of the R2VB geometry programs to be parsed properly, thus causing rendering issues.

Michaël KUGLER authored Sep 20, 2021 and Flavien BRIDAULT-LOUCHEZ committed Sep 21, 2021

The list containing the Ogre resources paths was not allocated properly.

Michaël KUGLER authored Sep 20, 2021 and Flavien BRIDAULT-LOUCHEZ committed Sep 20, 2021

style: apply sheldon


style: apply review suggestion
style: correct variable name


style: apply coding style


style: apply coding style


style: correct comment

Merge branch '769-feat-viz-add-optional-name-to-saxis-adaptor' into 'dev'

Closes #769

See merge request !619

Flat shading may often be broken if point normals are shared between faces. To overcome this, we chose to compute normals in the fragment shader using eye position derivatives. Doing so, the outdated and never used Gouraud shading mode was removed. This removes a shader combination, which makes maintenance easier.

Closes #652 and #766

Merge branch '766-confidential-issue' into 'dev'

See merge request !621

* if name is set, it will be displayed at axis origin
* Update Tuto15Matrix to display name to first SAxis, also reset camera at startup

Flat shading may often be broken if point normals are shared between faces. To overcome this, we chose to compute normals in the fragment shader using eye position derivatives.
Doing so, the outdated and never used Gouraud shading mode was removed. This removes a shader combination which makes maintenance easier.

The image copy using the image iterator is slow as hell in debug, making some applications unusable. This was replaced by a simple std::memcpy.

The deduction of the library path failed when share was already present in the main module path. The problem already occurred with module paths themselves, so the regex is now shared between these two places.


Merge branch '761-core-broken-library-path-on-external-projects-when-using-local-in-installation-paths' into 'dev'
Closes #761
See merge request sight/sight!614

The deduction of the library path failed when share was already present in the main module path. The problem already occurred with module paths themselves, so the regex is now shared between these two places.

### Main feature

Two services `sight::module::io::session::SReader` and `sight::module::io::session::SWriter` were implemented. They read/write a root data object from/to a session file on a filesystem.

The session file is indeed a standard "ZIP" archive, while the compression algorithm for files inside the session archive is ZSTD. A standard archive reader could open a session file, if it is able to handle ZIP archive with ZSTD compression.

The archive can be password protected using AES256 algorithm and the compression level is set individually, depending of the type of data to serialize.

The service configuration includes specifying the file extension and the password policy for encryption.

Configuration example:

```xml
<service type="sight::module::io::session::SReader">
    <inout key="data" uid="..." />
    <dialog extension=".sample" description="Sample Sight session file" policy=always/>
    <password policy="once" encryption="salted"/>
</service>
```

The dialog policy specifies when the open dialog is shown:

* **never**: never show the open dialog
* **once**: show only once, store the location as long as the service is started
* **always**: always show the location dialog
* **default**: default behavior, which is "always"

The password policy defines if we should protect the session file using a password and when to ask for it:

* **never**: a password will never be asked and the session file will never be encrypted.
* **once**: a password will be asked only once and stored in the memory for subsequent uses. The session file will be encrypted.
* **always**: a password will always be asked. The session file will be encrypted.
* **default**: uses the builtin default behavior which is "never".

The encryption policy defines if we uses the password as is or with salt. It can also be used to encrypt without password:

* **password**: Use the given password for encryption.
* **salted**: Use the given password with salt for encryption.
* **forced**: Force encryption with a pseudo random hidden password (if no password are provided).
* **default**: uses the builtin default behavior which is "password".

### General improvement:

* `ExActivities` has been modified to use the new session services instead of atoms
* new `TemporaryFile` class in `core::tools::System` that use ROII to delete the associated file as soon as the `TemporaryFile` class is destroyed.
* `core::tools::System::RobustRename()` now have an optional parameter to force renaming, even if the target already exists (it will be first deleted)
* `ui::base::Cursor` improvement: `BusyCursor`, `WaitCursor`, `CrossCursor` classes that use ROII to restore back "default" cursor, even if an exception occurs
* `ui::xxx::dialog::InputDialog` improvement: add a "bullet" mode for password field.
* `ui::xxx::dialog::MessageDialog` improvement: add a "retry" button.


Merge branch '752-io-drop-in-replacement-for-sreader-and-swriter-to-serialize-an-application-session' into 'dev'
Closes #752
See merge request sight/sight!606

Flavien BRIDAULT-LOUCHEZ authored Sep 03, 2021 and Didier WECKMANN committed Sep 06, 2021

The function failed when renaming from a EXT4 volume to a NTFS volume. This fixes detect the error and try another copy strategy.

- add a password mode for input dialog
- add ROII cursor and temporary file classes
- fixes regarding encryption

This MR fixes a crash upon selecting mesh in `dicomXplorer`.
The problem was simply that old configurations used in this software were deleted.

**It does not display the mesh in an activity.** It simply fixes the crash and re-enables the preview.

Closes #723
Merge branch '723-io-dicomxplorer-crahes-when-display-mesh-preview' into 'dev'
See merge request sight/sight!580